Skip to content

Ampers: Nicoleta Brandolini#30

Open
nbrandolini wants to merge 6 commits intoAda-C9:masterfrom
nbrandolini:master
Open

Ampers: Nicoleta Brandolini#30
nbrandolini wants to merge 6 commits intoAda-C9:masterfrom
nbrandolini:master

Conversation

@nbrandolini
Copy link

@nbrandolini nbrandolini commented Feb 12, 2018

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? To create instance variables for all the input attributes
Describe an instance variable you used and what you used it for. I used the planet variables to call information on planets
Describe what the difference would be if your SolarSystem used an Array vs a Hash. Hash is a key value pair, while array could iterate over the index.
Do you feel like you used consistent formatting throughout your code? I think so.

@nbrandolini
Copy link
Author

nbrandolini commented Feb 12, 2018

I still get an error on this but I am not able to figure out now what is wrong.

@nbrandolini
Copy link
Author

nbrandolini commented Feb 13, 2018

I am really sorry, here is my corrected version. Also, I noticed that when I use Beautify in Atom my "while true loop" changes in "loop do"? Is that true? I will appreciate any feedback or advice.
Thank you!

@tildeee
Copy link

tildeee commented Feb 14, 2018 •
edited
Loading

Solar System

What We're Looking For

Feature Feedback
Baseline
Readable code with consistent indentation. x
Primary Requirements
Created Custom Solar System Class with initialize, add planet & list planets methods, without using puts. x
Planet Class Created x
Created a collection of Planet objects as an instance variable in SolarSystem. x
Accessor methods created x
Method created to return the Planet's attributes and not use puts x
Created a user interface to interact with the SolarSystem including adding a planet and viewing a planet's details x
Additional Notes

Great job with Solar System!
For this submission, I reviewed the most recent files uploaded, and it was working when I graded it.

This project works and is written just as we expected

You did a great job making two classes, SolarSystem and Planet, which had defined its own states and behaviors. In fact, you did an excellent job utilizing and reusing the appropriate methods you defined.

I think your code is also very clean and readable.

Overall, good work!

Also, about Atom's Beautify recommending loop do:
I prefer it to be written while true do, but loop do is okay too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nbrandolini @tildeee